Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups

On 28 December 2016 at 22:16, Petr Jelinek <petr.jelinek@2ndquadrant.com> wrote:

> About the patch, it looks good to me for master with the minor exception
> that:
>> +             appendStringInfo(buf, "pageno %d, xid %u",
>> +                     trunc.pageno, trunc.oldestXid);
>
> This should probably say oldestXid instead of xid in the text description.

Agreed.

> About back-patching, I wonder if standby could be modified to move
> oldestXid based on pageno reverse calculation, but it's going to be
> slightly ugly.

Not worth it IMO.

-- Craig Ringer                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services