On Tue, Jan 10, 2012 at 3:09 PM, Dave Page
<dpage@pgadmin.org> wrote:
On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge
<
guillaume@lelarge.info> wrote:
> On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote:
>> Hi Dave
>>
>> Modified the logic. Attached is the patch file, please review it.
>>
>
> This is still wrong. bIsChangeComment isn't always true when the user
> creates a replication cluster. It's only true if there is a comment.
Seems a little long-winded too - can't you just replace the current
IsEmpty() test with something like "if (txtComment->GetValue() !=
cluster->GetComment())"?
No, I can't because when we create new Slony I-cluster "cluster->GetComment()" will not work as cluster object is NULL at that moment.
--
Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246