Re: Patch for SonarQube fixes.

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: Patch for SonarQube fixes.
Дата
Msg-id CANxoLDcUXdS45tEsk98SpPaX4Wh5YdErgPPM2B+JyOgmLddheQ@mail.gmail.com
обсуждение исходный текст
Ответ на Patch for SonarQube fixes.  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
Список pgadmin-hackers
Thanks, patch applied.

On Mon, Jan 18, 2021 at 11:15 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed a few sonarQube issues, PFA patch
Details as follows:

1. Preferences:
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
  • Merge this if statement with the enclosing one.
  • Define a constant instead of duplicating this literal 'tab settings' 5 times.
2. Connection:
  • Remove this unneeded "pass".
3. Sqleditor:
  • Remove this useless assignment to variable "msgDiv".
4. Debugger:
  • Review this useless assignment: "index" already holds the assigned value along all execution paths.
  • 'label' is already declared in the upper scope.
  • 'label' is already declared in the upper scope.
  • 'browser_preferences' is already declared in the upper scope.
5. FileManager:
  • 'path' is already declared in the upper scope.

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Remove few dependencies which are not required for ER
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin][RM1802] ERD Tool (Beta)