Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided
Дата
Msg-id CANxoLDfFM+LCVQPNJqVdjhv7zcZ30KMy6gxFoT9y2c85B_G+LA@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM4642] port should not be mandatory when a service is provided  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Can someone please review this.

On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the RM #4642 "port should not be mandatory when a service is provided". Cyril Jouve has sent the initial patch, but that only removes the validation on GUI, when we save the server properties without port and username backend throws an error because port and username is NOT NULL columns in the server table in SQLite.

I have removed the NOT NULL constraint from the port and username. The maintenance database is required as our whole connection logic is based on that, so I have added the NOT NULL constraint for that column.

Please review it.

--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgAdmin][RM4408] Show validation errors for slickgrid cells
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fix webpack issue where multiple assets emit to the s