On Thu, Feb 29, 2024 at 1:08 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> + /* TODO */
> + CHECK_SETOPT(actx, CURLOPT_WRITEDATA, stderr);
> I might be missing something, but what this is intended for in
> setup_curl_handles()?
Ah, that's cruft left over from early debugging, just so that I could
see what was going on. I'll remove it.
> --- /dev/null
> +++ b/src/interfaces/libpq/fe-auth-oauth-iddawc.c
> As discussed off-list I think we should leave iddawc support for later and
> focus on getting one library properly supported to start with. If you agree,
> let's drop this from the patchset to make it easier to digest. We should make
> sure we keep pluggability such that another library can be supported though,
> much like the libpq TLS support.
Agreed. The number of changes being folded into the next set is
already pretty big so I think this will wait until next+1.
--Jacob