Re: [HACKERS] fix side-effect in get_qual_for_list()

Поиск
Список
Период
Сортировка
От Jeevan Ladhe
Тема Re: [HACKERS] fix side-effect in get_qual_for_list()
Дата
Msg-id CAOgcT0P-PdDKKWR17qt_GZ-SpOC=GD+X1xULeEpkTR=acxoVyg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] fix side-effect in get_qual_for_list()  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Ответы Re: [HACKERS] fix side-effect in get_qual_for_list()  (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Ashutosh,

Thanks for catching this. For now this isn't a problem since
generate_partition_qual() is crafting PartitionBoundInfo which it
doesn't use anywhere else. But if the function gets used where the
PartitionBoundSpec is being used somewhere else as well.

Yes, this behavior currently does not affect adversely, but I think this
function is quite useful for future enhancements and should be fixed.

While you are
at it, can we use castNode() in place of
PartitionBoundSpec *spec = (PartitionBoundSpec *) bound; Or do you
think it should be done separately?

I have made this change at couple of places applicable.

PFA.

Regards,
Jeevan Ladhe 
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Renaming a table to an array's autogenerated name
Следующее
От: Vik Fearing
Дата:
Сообщение: Re: [HACKERS] Renaming a table to an array's autogenerated name