Multi-insert related comment in CopyFrom()

Поиск
Список
Период
Сортировка
От Etsuro Fujita
Тема Multi-insert related comment in CopyFrom()
Дата
Msg-id CAPmGK14VGf-xQjGQN4o1QyAbXAaxugU5=qfcmTDh1iufUDnV_w@mail.gmail.com
обсуждение исходный текст
Ответы Re: Multi-insert related comment in CopyFrom()  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Список pgsql-hackers
Hi,

While working on the “Fast COPY FROM based on batch insert” patch, I
noticed this:

    else if (proute != NULL && resultRelInfo->ri_TrigDesc != NULL &&
             resultRelInfo->ri_TrigDesc->trig_insert_new_table)
    {
        /*
         * For partitioned tables we can't support multi-inserts when there
         * are any statement level insert triggers. It might be possible to
         * allow partitioned tables with such triggers in the future, but for
         * now, CopyMultiInsertInfoFlush expects that any before row insert
         * and statement level insert triggers are on the same relation.
         */
        insertMethod = CIM_SINGLE;
    }

I think there is a thinko in the comment; “before” should be after.
Patch attached.

Best regards,
Etsuro Fujita

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: a.kozhemyakin@postgrespro.ru
Дата:
Сообщение: Re: tweak to a few index tests to hits ambuildempty() routine.
Следующее
От: "wangw.fnst@fujitsu.com"
Дата:
Сообщение: RE: Perform streaming logical transactions by background workers and parallel apply