Hi,
On Fri, May 14, 2021 at 9:00 PM Zhihong Yu <zyu@yugabyte.com> wrote:
> Searching postgres codebase reveals the following (partial) examples:
>
> bool is_varlena
> bool is_leaf
>
> I think these are more intuitive.
>
> If you think is_in_async_mode is too long, how about naming the parameter is_async ?
Sorry, I don’t think we need to rename the parameter, because I think
async_mode is also a good name for it, and the naming follows that of
existing parameters in our codebase, such as hash_spill_mode and
csv_mode in the CopyFormatOptions struct.
I think this would be just a matter of preference.
Best regards,
Etsuro Fujita