pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ.
Дата
Msg-id E1b5xZY-0001iW-5j@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Make pg_dump behave more sanely when built without HAVE_LIBZ.

For some reason the code to emit a warning and switch to uncompressed
output was placed down in the guts of pg_backup_archiver.c.  This is
definitely too late in the case of parallel operation (and I rather
wonder if it wasn't too late for other purposes as well).  Put it in
pg_dump.c's option-processing logic, which seems a much saner place.

Also, the default behavior with custom or directory output format was
to emit the warning telling you the output would be uncompressed.  This
seems unhelpful, so silence that case.

Back-patch to 9.3 where parallel dump was introduced.

Kyotaro Horiguchi, adjusted a bit by me

Report: <20160526.185551.242041780.horiguchi.kyotaro@lab.ntt.co.jp>

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f2f18a37c335384240c4f6b5ebbed4678ae8949c

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 10 ----------
src/bin/pg_dump/pg_dump.c            |  9 +++++++++
2 files changed, 9 insertions(+), 10 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: In Windows pg_dump, ensure idle workers will shut down during er
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ.