pgsql: Fix failures with TAP tests of pg_ctl on Windows

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pgsql: Fix failures with TAP tests of pg_ctl on Windows
Дата
Msg-id E1ibzOK-0002Wr-0H@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix failures with TAP tests of pg_ctl on Windows

On Windows, all the hosts spawned by the TAP tests bind to 127.0.0.1.
Hence, if there is a port conflict, starting a cluster would immediately
fail.  One of the test scripts of pg_ctl initializes a node without
PostgresNode.pm, using the default port 5432.  This could cause
unexpected startup failures in the tests if an independent server was up
and running on the same host (the reverse is also possible, though more
unlikely).  Fix this issue by assigning properly a free port to the node
configured, in the same range used as for the other nodes part of the
tests.

Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20191202031444.GC1696@paquier.xyz
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8fd28a7baaccaba89987f9628632e9c39235c6b5

Modified Files
--------------
src/bin/pg_ctl/t/001_start_stop.pl | 2 ++
1 file changed, 2 insertions(+)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: pgsql: Fix failures with TAP tests of pg_ctl on Windows
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: Add a regression test for allow_system_table_mods