Remove XLogFileNameP() from the tree
XLogFileNameP() is a wrapper routine able to build a palloc'd string for
a WAL segment name, which is used for error string generation. There
were several code paths where it gets called in a critical section,
where memory allocation is not allowed. This results in triggering
an assertion failure instead of generating the wanted error message.
Another, more annoying, problem is that if the allocation to generate
the WAL segment name fails on OOM, then the failure would be escalated
to a PANIC.
This removes the routine and all its callers are replaced with a logic
using a fixed-size buffer. This way, all the existing mistakes are
fixed and future ones are prevented.
Author: Masahiko Sawada
Reviewed-by: Michael Paquier, Álvaro Herrera
Discussion: https://postgr.es/m/CA+fd4k5gC9H4uoWMLg9K_QfNrnkkdEw+-AFveob9YX7z8JnKTA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9989d37d1c8dff12f20a1de8e1f470093136c893
Modified Files
--------------
src/backend/access/transam/xlog.c | 88 ++++++++++++++++++++++------------
src/backend/access/transam/xlogutils.c | 6 ++-
src/backend/replication/walreceiver.c | 30 ++++++++----
src/backend/replication/walsender.c | 9 +++-
src/include/access/xlog.h | 1 -
src/include/access/xlog_internal.h | 4 ++
6 files changed, 95 insertions(+), 43 deletions(-)