Fix 'skip-empty-xacts' option in test_decoding for streaming mode.
In streaming mode, the transaction can be decoded in multiple streams and
those streams can be interleaved with streams of other transactions. So,
we can't remember the transaction's write status in the logical decoding
context because that might get changed due to some other transactions and
lead to wrong answers for 'skip-empty-xacts' option. We decided to keep
each transaction's write status in the ReorderBufferTxn to avoid
interleaved streams changing the status of some unrelated transactions.
Diagnosed-by: Amit Kapila
Author: Dilip Kumar
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CAA4eK1LR7=XNM_TLmpZMFuV8ZQpoxkem--NZJYf8YXmesbvwLA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9653f24ad8307f393de51e0a64d9b10a49efa6e3
Modified Files
--------------
.../test_decoding/expected/concurrent_stream.out | 5 +-
contrib/test_decoding/specs/concurrent_stream.spec | 10 ++-
contrib/test_decoding/test_decoding.c | 93 ++++++++++++++++++----
src/backend/replication/logical/reorderbuffer.c | 1 +
src/include/replication/reorderbuffer.h | 5 ++
src/tools/pgindent/typedefs.list | 1 +
6 files changed, 96 insertions(+), 19 deletions(-)