pgsql: Fix places in TestLib.pm in need of adaptation to the output of

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pgsql: Fix places in TestLib.pm in need of adaptation to the output of
Дата
Msg-id E1mSpRd-0007jS-Ax@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix places in TestLib.pm in need of adaptation to the output of Msys perl

Contrary to the output of native perl, Msys perl generates outputs with
CRLFs characters.  There are already places in the TAP code where CRLFs
(\r\n) are automatically converted to LF (\n) on Msys, but we missed a
couple of places when running commands and using their output for
comparison, that would lead to failures.

This problem has been found thanks to the test added in 5adb067 using
TestLib::command_checks_all(), but after a closer look more code paths
were missing a filter.

This is backpatched all the way down to prevent any surprises if a new
test is introduced in stable branches.

Reviewed-by: Andrew Dunstan, Álvaro Herrera
Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us
Backpatch-through: 9.6

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/90251ff199858844fa450ba9614092c06c67fc4f

Modified Files
--------------
src/test/perl/TestLib.pm | 5 +++++
1 file changed, 5 insertions(+)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Fix misevaluation of STABLE parameters in CALL within plpgsql.
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: Support "postgres -C" with runtime-computed GUCs