pgsql: postgres_fdw: Refactor transaction rollback code to avoid code d

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема pgsql: postgres_fdw: Refactor transaction rollback code to avoid code d
Дата
Msg-id E1mT3YM-0004YB-AE@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
postgres_fdw: Refactor transaction rollback code to avoid code duplication.

In postgres_fdw, pgfdw_xact_callback() and pgfdw_subxact_callback()
callback functions do almost the same thing to rollback remote toplevel-
and sub-transaction. But previously their such rollback logics were
implemented separately in each function and in different way. Which
could decrease the readability and maintainability of the code.

To fix the issue, this commit creates the common function to rollback
remote transactions, and makes those callback functions use it. Which
allows us to avoid unnecessary code duplication.

Author: Fujii Masao
Reviewed-by: Zhihong Yu, Bharath Rupireddy
Discussion: https://postgr.es/m/62fbb63a-d46c-fb47-a56d-f6be1909aa44@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/85c69611288f4096b7460d980bedaa777f824d24

Modified Files
--------------
contrib/postgres_fdw/connection.c | 177 ++++++++++++++++----------------------
1 file changed, 75 insertions(+), 102 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Следующее
От: Peter Geoghegan
Дата:
Сообщение: pgsql: Document issue with heapam line pointer truncation.