pgsql: Improve error messages for some callers of XLogReadRecord()

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pgsql: Improve error messages for some callers of XLogReadRecord()
Дата
Msg-id E1mke2E-0003ve-MO@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Improve error messages for some callers of XLogReadRecord()

A couple of code paths related to logical decoding (WAL sender, slot
advancing, etc.) use XLogReadRecord(), feeding on error messages
generated by walreader.c on a failure.  All those messages have no
context, making it harder to spot from where an error could come even if
these should not happen.  All the other callers of XLogReadRecord() do
that already.

Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/YYnTH6OyOwQcAdkw@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c9c401a5e13accc4a3a775e3feeabdc5940c9178

Modified Files
--------------
src/backend/replication/logical/logical.c      | 4 ++--
src/backend/replication/logical/logicalfuncs.c | 2 +-
src/backend/replication/slotfuncs.c            | 3 ++-
src/backend/replication/walsender.c            | 3 ++-
4 files changed, 7 insertions(+), 5 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Jeff Davis
Дата:
Сообщение: pgsql: Add pg_checkpointer predefined role for CHECKPOINT command.
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Fix incorrect format placeholders