Teach remove_unused_subquery_outputs about window run conditions
9d9c02ccd added code to allow the executor to take shortcuts when quals
on monotonic window functions guaranteed that once the qual became false
it could never become true again. When possible, baserestrictinfo quals
are converted to become these quals, which we call run conditions.
Unfortunately, in 9d9c02ccd, I forgot to update
remove_unused_subquery_outputs to teach it about these run conditions.
This could cause a WindowFunc column which was unused in the target list
but referenced by an upper-level WHERE clause to be removed from the
subquery when the qual in the WHERE clause was converted into a window run
condition. Because of this, the entire WindowClause would be removed from
the query resulting in additional rows making it into the resultset when
they should have been filtered out by the WHERE clause.
Here we fix this by recording which target list items in the subquery have
run conditions. That gets passed along to remove_unused_subquery_outputs
to tell it not to remove these items from the target list.
Bug: #17495
Reported-by: Jeremy Evans
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/17495-7ffe2fa0b261b9fa@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3e9abd2eb1b1f6863250f060290f514f30ce8044
Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 50 +++++++++++++++++++++++++++--------
src/backend/parser/parse_clause.c | 1 +
src/test/regress/expected/window.out | 19 +++++++++++++
src/test/regress/sql/window.sql | 10 +++++++
4 files changed, 69 insertions(+), 11 deletions(-)