Expand regression tests of pg_stat_statements for utility queries
This commit adds more coverage for utility statements so as it is
possible to track down all the effects of query normalization done for
all the queries that use either Const or A_Const nodes, which are the
nodes where normalization makes the most sense as they apply to
constants (well, most of the time, really).
This set of queries is extracted from an analysis done while looking at
full dumps of the regression database when applying different levels of
normalization to either Const or A_Const nodes for utilities, as of a
minimal set of these, for:
- All relkinds (CREATE, ALTER, DROP)
- Policies
- Cursors
- Triggers
- Types
- Rules
- Statistics
- CALL
- Transaction statements (isolation level, options)
- EXPLAIN
- COPY
Note that pg_stat_statements is not switched yet to show any
normalization for utilities, still it improves the default coverage of
the query jumbling code (not by as much as enabling query jumbling on
the main regression test suite, though):
- queryjumblefuncs.funcs.c: 36.8% => 48.5%
- queryjumblefuncs.switch.c: 33.2% => 43.1%
Reviewed-by: Bertrand Drouvot
Discussion: https://postgr.es/m/Y+MRdEq9W9XVa2AB@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/de2aca288569fd0cabb425c0858e92e2c8c938cb
Modified Files
--------------
contrib/pg_stat_statements/Makefile | 3 +-
contrib/pg_stat_statements/expected/cursors.out | 70 ++++
contrib/pg_stat_statements/expected/utility.out | 468 ++++++++++++++++++++++--
contrib/pg_stat_statements/meson.build | 1 +
contrib/pg_stat_statements/sql/cursors.sql | 30 ++
contrib/pg_stat_statements/sql/utility.sql | 232 +++++++++++-
6 files changed, 774 insertions(+), 30 deletions(-)