No actually, I'm quite confident of it - it works perfectly on my computer
and does exactly what it's supposed to do. I have tested it extensively.
It also works in a transaction and gets rolled back properly. However, I
haven't tested it with multiple backends simultaneously doing stuff. I'm
pretty sure there won't be anything wrong with it though...
It's the stylistic stuff I don't know about. For example, I issue a NOTICE
if more than one constraint was removed - I don't know if this is desirable
behaviour from the viewpoint of you guys (I personally think it's very
important!).
But hey...
Chris
> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> Sent: Tuesday, 22 May 2001 7:13 PM
> To: Christopher Kings-Lynne
> Cc: pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] DROP CONSTRAINT patch
>
>
> > Anyone looked at this yet?
> >
> > Also, if someone could tell me where I should attempt to add a
> regression
> > test and what, exactly, I should be regression testing it would be
> > helpful...
>
> I was hoping someone else would comment on it. I will check it out
> later and either apply or comment. You seemed little uncertain of it so
> I left it in my mailbox for a while.
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman@candle.pha.pa.us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>