> On 26 Apr 2023, at 12:18, Andreas 'ads' Scherbaum <ads@pgug.de> wrote:
>
>
> Hello,
>
> pg_dumpall.c has a function dumpRoleMembership() which dumps all
> membership roles. This function includes a piece of code which checks
> if the membership tree has an open end which can't be resolved.
> However that code is never used.
>
> The variable prev_remaining is initially set to 0, and then never changed.
> Which in turn never executes this code:
>
> if (remaining == prev_remaining)
>
> because the loop is only entered while "remaining > 0".
>
> The attached patch fixes this problem, and updates prev_remaining inside
> the loop.
Nice catch, that indeed seems like a proper fix. This was introduced in
ce6b672e44 and so doesn't need a backpatch.
--
Daniel Gustafsson