Re: Frustrating issue with PGXS

Поиск
Список
Период
Сортировка
От Fabien COELHO
Тема Re: Frustrating issue with PGXS
Дата
Msg-id Pine.LNX.4.64.0706261635470.8254@briare.cri.ensmp.fr
обсуждение исходный текст
Ответ на Re: Frustrating issue with PGXS  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Frustrating issue with PGXS  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения 
> Let's add the ifndef to Makefile.global and change the
> existing extension makefiles to
>
>     PG_CONFIG := pg_config
>     PGXS := $(shell $(PG_CONFIG) --pgxs)
>     include $(PGXS)
>
> Any objections?

Maybe the ":=" for pg_config is not necessary, "=" is fine for a 
simple string definition ?

Some documentation (not just code) update seems important to me. The patch 
I sent which describes the current status may be applied to existing 
branches, and something else can be written for the explicit PG_CONFIG 
setting.

Otherwise it looks okay AFAIC.

-- 
Fabien.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Gregory Stark
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords