[patch] Adding an assertion to report too long hash table name

Поиск
Список
Период
Сортировка
От Xiaoran Wang
Тема [patch] Adding an assertion to report too long hash table name
Дата
Msg-id SN6PR05MB4462E92F19E927AF41AC468FBA579@SN6PR05MB4462.namprd05.prod.outlook.com
обсуждение исходный текст
Ответы Re: [patch] Adding an assertion to report too long hash table name  (Junwang Zhao <zhjwpku@gmail.com>)
Re: [patch] Adding an assertion to report too long hash table name  (Zhang Mingli <zmlpostgres@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi,

The max size for the shmem hash table name is SHMEM_INDEX_KEYSIZE - 1. 
but when the caller uses a longer hash table name, it doesn't report any error, instead
it just uses the first SHMEM_INDEX_KEYSIZE -1 chars as the hash table name.

I created some shmem hash tables with the same prefix which was longer than
SHMEM_INDEX_KEYSIZE - 1, and the size of those hash tables were the same,
then only one hash table was created. But I thought those hash tables were created
successfully.

I know this is a corner case, but it's difficult to figure it out when run into it. So I add
an assertion to prevent it.


Thanks,
Xiaoran
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: A potential memory leak on Merge Join when Sort node is not below Materialize node
Следующее
От: Andres Freund
Дата:
Сообщение: Re: longfin and tamandua aren't too happy but I'm not sure why