Re: GetSubscriptionRelations declares too many scan keys

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: GetSubscriptionRelations declares too many scan keys
Дата
Msg-id YJo3VscSxCQnoy1h@paquier.xyz
обсуждение исходный текст
Ответ на Re: GetSubscriptionRelations declares too many scan keys  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: GetSubscriptionRelations declares too many scan keys  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Дерево обсуждения 
On Mon, May 10, 2021 at 10:14:08AM -0400, Tom Lane wrote:
> Yeah, there's no real consensus about that.  But in this case there's
> a strong reason to use skey[1]: it makes the patch a very safe one-liner.
> To convert to the other pattern would require touching more code.

FWIW, what Peter S has done looks fine to me, even if it is true that
CountDBSubscriptions() uses one scan key but does not use an array.

And that makes the code slightly easier to follow.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Julien Rouhaud
Дата:
Сообщение: Re: compute_query_id and pg_stat_statements
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: autovacuum: handle analyze for partitioned tables