Re: Two patches to speed up pg_rewind.

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Two patches to speed up pg_rewind.
Дата
Msg-id YLcVCgnXTKidYfvG@paquier.xyz
обсуждение исходный текст
Ответ на Re: Two patches to speed up pg_rewind.  (Paul Guo <guopa@vmware.com>)
Ответы Re: Two patches to speed up pg_rewind.  (Thomas Munro <thomas.munro@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
On Fri, May 28, 2021 at 05:30:51AM +0000, Paul Guo wrote:
> Did some small modification and rebased the code. See attached for the new version.

Regarding patch 0002, I find the inter-dependencies between
write_target_range() and copy_target_range() a bit confusing.  There
is also a bit of duplication for dry_run, fetch_done and the progress
reporting.  Perhaps it would be cleaner to have a fallback
implementation of copy_file_range() in src/port/ and reduce the
footprint of the patch in pg_rewind?

Note: FreeBSD 13~ has support for copy_file_range(), nice..  Adding
Thomas in CC in case I am missing something.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Speed up pg_checksums in cases where checksum already set
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Alias collision in `refresh materialized view concurrently`