Re: pgsql: Add various assertions to heap pruning code.

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pgsql: Add various assertions to heap pruning code.
Дата
Msg-id YYTTuYykpVXEfnOr@paquier.xyz
обсуждение исходный текст
Ответ на pgsql: Add various assertions to heap pruning code.  (Peter Geoghegan <pg@bowt.ie>)
Ответы Re: pgsql: Add various assertions to heap pruning code.  (Peter Geoghegan <pg@bowt.ie>)
Список pgsql-committers
Hi Peter,

On Fri, Nov 05, 2021 at 02:09:47AM +0000, Peter Geoghegan wrote:
> Add various assertions to heap pruning code.
>
> These assertions document (and verify) our high level assumptions about
> how pruning can and cannot affect existing items from target heap pages.
> For example, one of the new assertions verifies that pruning does not
> set a heap-only tuple to LP_DEAD.

This generates some warnings on Windows without asserts:
pruneheap.c(847): warning C4101: 'htup' unreferenced local variable
pruneheap.c(859): warning C4101: 'tolp' unreferenced local variable

You could move those two variables within their USE_ASSERT_CHECKING
blocks, for example.

Thanks,
--
Michael

Вложения

В списке pgsql-committers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: pgsql: Improve psql tab completion for COMMENT
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: pgcrypto: Remove non-OpenSSL support