pg_stop_backup() v2 incorrectly marked as proretset

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема pg_stop_backup() v2 incorrectly marked as proretset
Дата
Msg-id Yh8guT78f1Ercfzw@paquier.xyz
обсуждение исходный текст
Ответы Re: pg_stop_backup() v2 incorrectly marked as proretset  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Re: pg_stop_backup() v2 incorrectly marked as proretset  (Chapman Flack <chap@anastigmatix.net>)
Список pgsql-hackers
Hi all,

In my hunt looking for incorrect SRFs, I have noticed a new case of a
system function marked as proretset while it builds and returns only
one record.  And this is a popular one: pg_stop_backup(), labelled
v2.

This leads to a lot of unnecessary work, as the function creates a
tuplestore it has no need for with the usual set of checks related to
SRFs.  The logic can be be simplified as of the attached.

Thoughts?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: Add the replication origin name and commit-LSN to logical replication worker errcontext
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Design of pg_stat_subscription_workers vs pgstats