Re: [BUG] pg_stat_statements and extended query protocol

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [BUG] pg_stat_statements and extended query protocol
Дата
Msg-id ZC0AC7L35HZbK82p@paquier.xyz
обсуждение исходный текст
Ответ на Re: [BUG] pg_stat_statements and extended query protocol  ("Imseih (AWS), Sami" <simseih@amazon.com>)
Ответы Re: [BUG] pg_stat_statements and extended query protocol  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Wed, Apr 05, 2023 at 04:07:21AM +0000, Imseih (AWS), Sami wrote:
>> - es_processed: number of tuples processed during one ExecutorRun()
>> call.
>> - es_total_processed: total number of tuples aggregated across all
>> ExecutorRun() calls.
>
> I thought hard about this point and for some reason I did not want to
> mention ExecutorRun in the comment. But, I agree with what you suggest.
> It's more clear as to the intention of the fields.
>
> Attached is v5 addressing the comments.

Thanks, this should be enough to persist the number of tuples tracked
across multiple ExecutorRun() calls.  This looks pretty good to me.

We should do something about providing more control over that to
libpq in the long run, IMO, and have more test coverage, but let's see
about that in 17~.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: what should install-world do when docs are not available?
Следующее
От: "Koshi Shibagaki (Fujitsu)"
Дата:
Сообщение: Fix code comment in postgres_fdw.c