On 2018/05/09 13:14, Amit Langote wrote:
> Hi David.
>
> Thanks for addressing my comments.
>
> On 2018/05/07 15:00, David Rowley wrote:
>> v2 patch is attached.
>
> Looks good to me.
Sorry, I should've seen noticed v3 before sending my email.
v3 looks good too, but when going through it, I noticed one bit in 5.10.4.
Partitioning and Constraint Exclusion:
A good rule of thumb is that partitioning constraints should
contain only comparisons of the partitioning column(s) to constants
using B-tree-indexable operators, which applies even to partitioned
tables, because only B-tree-indexable column(s) are allowed in the
partition key.
I think the part after ", which applies even to partitioned tables,.."
should be removed.
Attached find the updated patch.
Thanks,
Amit