On 2022-12-26 Mo 18:00, Tom Lane wrote:
> I wrote:
>> (Perhaps we should go further than this, and convert all these
>> functions to just be DirectInputFunctionCallSafe wrappers
>> around the corresponding input functions? That would save
>> some duplicative code, but I've not done it here.)
> I looked closer at that idea, and realized that it would do more than
> just save some code: it'd cause the to_regfoo functions to accept
> numeric OIDs, as they did not before (and are documented not to).
> It is unclear to me whether that inconsistency with the input
> functions is really desirable or not --- but I don't offhand see a
> good argument for it. If we change this though, it should probably
> happen in a separate commit. Accordingly, here's a delta patch
> doing that.
>
>
+1 for doing this. The code simplification is nice too.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com