Re: Always bump PG_CONTROL_VERSION?

Поиск
Список
Период
Сортировка
От Jan Wieck
Тема Re: Always bump PG_CONTROL_VERSION?
Дата
Msg-id ae241c1c-363a-9741-ab1c-a62f7278f6a8@wi3ck.info
обсуждение исходный текст
Ответ на Re: Always bump PG_CONTROL_VERSION?  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Always bump PG_CONTROL_VERSION?  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Always bump PG_CONTROL_VERSION?  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
On 5/12/21 10:04 PM, Michael Paquier wrote:
> On Wed, May 12, 2021 at 01:30:27PM -0700, Andres Freund wrote:
>> That said, I don't think it's a good practice to use the control file
>> version as an identifier for the major version. Who knows, it might be
>> necessary to add an optional new format in a minor version at some point
>> or such crazyness. And then there's the beta stuff you'd mentioned, etc.
> 
> Yes, PG_VERSION, as you wrote upthread already, is already fine for
> the job, and FWIW, I have yet to see a case where being able to easily
> detect the minor version in a data folder matters.

Regardless of PG_VERSION doing the job or not, shouldn't there be a bump 
in PG_CONTROL_VERSION whenever there is a structural or semantic change 
in the control file data? And wouldn't the easiest way to ensure that be 
to bump the version with every release?

Also, can someone give me a good reason NOT to bump the version?


Thanks, Jan

-- 
Jan Wieck
Postgres User since 1994



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michail Nikolaev
Дата:
Сообщение: Re: [PATCH] Full support for index LP_DEAD hint bits on standby
Следующее
От: Tom Lane
Дата:
Сообщение: Re: OOM in spgist insert