On 3/10/22 12:07, Peter Eisentraut wrote:
> On 23.02.22 00:24, Tomas Vondra wrote:
>> Here's an updated version of the patch, fixing most of the issues from
>> reviews so far. There's still a couple FIXME comments, but I think those
>> are minor and/or straightforward to deal with.
>
> This patch needs a rebase because of a conflict in
> expected/publication.out. In addition, see the attached fixup patch to
> get the pg_dump tests passing (and some other stuff).
>
OK, rebased patch attached.
> 028_sequences.pl should be renamed to 029, since there is now another 028.
>
Renamed.
> In psql, the output of \dRp and \dRp+ is inconsistent. The former shows
>
> All tables | All sequences | Inserts | Updates | Deletes | Truncates |
> Sequences | Via root
>
> the latter shows
>
> All tables | All sequences | Inserts | Updates | Deletes | Sequences |
> Truncates | Via root
>
> I think the first order is the best one.
>
Good idea, I've tweaked the code to use the former order.
> That's all for now, I'll come back with more reviewing later.
thanks
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company