On 2022-12-23 Fr 13:53, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 2022-12-22 Th 11:44, Tom Lane wrote:
>>> (I wonder why this is using RE_compile_and_cache at all, really,
>>> rather than some other API. There doesn't seem to be value in
>>> forcing the regex into the cache at this point.)
>> I agree. The attached uses pg_regcomp instead. I had a lift a couple of
>> lines from regexp.c, but not too many.
> LGTM. No further comments.
>
>
As I was giving this a final polish I noticed this in jspConvertRegexFlags:
/*
* We'll never need sub-match details at execution. While
* RE_compile_and_execute would set this flag anyway, force it on
here to
* ensure that the regex cache entries created by makeItemLikeRegex are
* useful.
*/
cflags |= REG_NOSUB;
Clearly the comment would no longer be true. I guess I should just
remove this?
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com