On 22.05.24 18:15, Sriram RK wrote:
> Please find the attached patch.
>
> Apart from the AIX specific changes, there is a minor change in this
> file wrt to XLC, below is the error for which we removed inline.
>
> Later, the build and tests passed for both XLC(16.1.0.18) and gcc(12) as
> well.
I think what you should do next is aggressively trim anything that does
not apply to current versions of AIX or the current compiler.
For example,
+ # Old xlc versions (<13.1) don't have support for -qvisibility. Use
expfull to force
+ <para>
+ <productname>AIX</productname> versions before 7.1 are no longer
+ tested nor supported by the <productname>PostgreSQL</productname>
+ community.
+ </para>
(Probably most of that section needs to be retested and rewritten.)
+ # Native memset() is faster, tested on:
+ # - AIX 5.1 and 5.2, XLC 6.0 (IBM's cc)
+ # - AIX 5.3 ML3, gcc 4.0.1
+ memset_loop_limit = 0
+ # for the base executable (AIX 4.2 and up)
+ * "IBM XL C/C++ for AIX, V12.1" miscompiles, for 32-bit, some inline
One of the reasons that the AIX port ultimately became unmaintainable
was that so many hacks and caveats were accumulated over the years. A
new port should set a more recent baseline and trim all those hacks.