On 2020-02-03 13:47, Andres Freund wrote:
> Comment:
>
> - It'd be good to split out the feature independent refactorings, like
> the introduction of InitControlFile(), into their own commit. Right
> now it's hard to separate out what should just should be moved code,
> and what should be behavioural changes. Especially when there's stuff
> like just reindenting comments as part of the patch.
Agreed. Here are three refactoring patches extracted that seem useful
on their own.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services