Re: Incorrect email address in the auth.py module

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Incorrect email address in the auth.py module
Дата
Msg-id zZs-Ir-mezjBf_tvR4hOaHXDvpOlWa652ocaIKmY9E2E5t06xAZ0_iNgW_qFQe-XHHnY4bF2X4T3deFJmZCm1QJ7_VXA3gAhsfgQEsH0-zI=@yesql.se
обсуждение исходный текст
Ответ на Re: Incorrect email address in the auth.py module  (Magnus Hagander <magnus@hagander.net>)
Ответы Re: Incorrect email address in the auth.py module
Список pgsql-www
On Wednesday, March 27, 2019 3:51 PM, Magnus Hagander <magnus@hagander.net> wrote:

On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel@yesql.se> wrote:
Poking around in the CF app I noticed that the auth.py module for integrating with
the community authentication was out of sync with the copy in the main pgweb repo.
Turns out the copy in the CF app is the most up to date as it has fixed the email
address in the account merging support email template. The attached patch merges
the changes from the CF app copy into the one in the pgweb repo. Unless there are
objections I plan to apply this soon.

This also fixes an adjacent typo spotted in the process.

That update breaks the commit hook. Have you perhaps forgotten to instlall it? :)

Aha, nice catch. This repo does indeed not run any commit hooks, will fix.

Please make sure that a "pep8" run (with version 2.2.0 or compatible, as that's what's used on the prod servers) passes on the code before pushing! Easiest way is to make sure that the tools/githook/pre-commit is linked into your git hooks directory.

Gotcha, thanks. Any objections to the patch when the above mentioned breakage is resolved?

cheers ./daniel

В списке pgsql-www по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: Redundant role attribute on the CF app
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: Incorrect email address in the auth.py module