Обсуждение: CVS Commit by dpage: log_filename is only in 8+

Log Message:
-----------
log_filename is only in 8+

Modified Files:
--------------
    pgadmin3/src/db:
        pgConn.cpp (r1.55 -> r1.56)

cvs@cvs.pgadmin.org wrote:
> Log Message:
> -----------
> log_filename is only in 8+

No need to check this here; it's already done in frmStatus.
Additionally, pgadmin3 shouldn't bother about logfilename formats known
to the backend; this might change any time.

Regards,
Andreas

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 05 September 2004 18:18
> To: pgadmin-hackers@postgresql.org; Dave Page
> Subject: Re: [pgadmin-hackers] CVS Commit by dpage:
> log_filename is only in 8+
>
> cvs@cvs.pgadmin.org wrote:
> > Log Message:
> > -----------
> > log_filename is only in 8+
>
> No need to check this here; it's already done in frmStatus.

Well it wasn't working then as it barfed when I ran on 7.3. Though if
you look more closely at the patch, you'll see that I was restricting
the SHOW logfilename; query to 8+.

> Additionally, pgadmin3 shouldn't bother about logfilename
> formats known to the backend; this might change any time.

Yes, it might - and if it does, pg_logdir_ls will fail gracefully with
an error because it can't parse the timestamp - and even if we made it
much more clever, there are still a million and one formats in which we
won't be able to figure out the timestamp. The reason pgAdmin does this
check is so that we a) only do it once and b) we can hide the log tab in
the same way as we do if pg_logdir_ls doesn't exist.

Regards, Dave.

Dave Page wrote:
>

>
> Well it wasn't working then as it barfed when I ran on 7.3.

Strange, the logfile page is removed for <8 and FEATURE_FILEREAD not
existing, this should be enough.

Regards,
Andreas

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 06 September 2004 08:45
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] CVS Commit by dpage:
> log_filename is only in 8+
>
> Dave Page wrote:
> >
>
> >
> > Well it wasn't working then as it barfed when I ran on 7.3.
>
> Strange, the logfile page is removed for <8 and
> FEATURE_FILEREAD not existing, this should be enough.

Yes, but the SHOW log_filename was still executed, which is why I added
the >8 check.

/D