Обсуждение: Errors & notices in pgAdmin log-files broken

Hi developers! Hi Dave!

Testing pgAdmin v.1.8.2 (Feb 5 2008), rev: 7050, on WinXP; host: pg 8.2.6 on
Debian Etch


pgAdmin does not log errors or notices, if I chose
    [x] Errors only
or
    [x] Errors and Notices
in the setting in File->Options->Logging. Actually, nothing is logged at all.

If set it to
    [x] Errors, Notices, SQL
or
    [x] Debug (not recommended for normal use)
I get two copies (!) of notices, but still not errors. SQL & Debug stuff
seems to work.


The following example should give me 1 SQL statement, 1 notice and 1 error in
the log file. The name for the primary key has been used before.
(Do you need the German part translated? HINWEIS = NOTICE, FEHLER = ERROR.)


CREATE TABLE foo (foo_id integer, CONSTRAINT event_pkey PRIMARY KEY (foo_id));


Message in SQL window:
~~~~~~~~~~~~~~~~~~~~~~
HINWEIS:  CREATE TABLE / PRIMARY KEY erstellt implizit einen Index
»event_pkey« für Tabelle »foo«

FEHLER:  Relation »event_pkey« existiert bereits

********** Error **********

FEHLER: Relation »event_pkey« existiert bereits
SQL state: 42P07


Log file:
~~~~~~~~~
2008-03-28 20:53:35 QUERY  : Thread Query CREATE TABLE foo (foo_id integer,
CONSTRAINT event_pkey PRIMARY KEY (foo_id));
2008-03-28 20:53:35 QUERY  : HINWEIS:  CREATE TABLE / PRIMARY KEY erstellt
implizit einen Index »event_pkey« für Tabelle »foo«

2008-03-28 20:53:35 QUERY  : HINWEIS:  CREATE TABLE / PRIMARY KEY erstellt
implizit einen Index »event_pkey« für Tabelle »foo«



Regards
Erwin

P.S.: The SQL window tries to make up for the log file and states the error
message twice, thus restoring balance of things.

On Fri, Mar 28, 2008 at 9:16 PM, Erwin Brandstetter
<brandstetter@falter.at> wrote:
> Hi developers! Hi Dave!
>
>  Testing pgAdmin v.1.8.2 (Feb 5 2008), rev: 7050, on WinXP; host: pg 8.2.6
> on Debian Etch
>
>
>  pgAdmin does not log errors or notices, if I chose
>         [x] Errors only
>  or
>         [x] Errors and Notices
>  in the setting in File->Options->Logging. Actually, nothing is logged at
> all.
>
>  If set it to
>         [x] Errors, Notices, SQL
>  or
>         [x] Debug (not recommended for normal use)
>  I get two copies (!) of notices, but still not errors. SQL & Debug stuff
> seems to work.
>

Thanks Erwin - I've committed a fix which I believe resolves all these issues.

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com