Обсуждение: patch to fix pgadmin1.8.4 build on Solaris 10.
Hello, While building pgadmin 1.8.4 on Solaris 10, I encountered following error. "./debugger/dbgPgConn.cpp", line 97: Error: INADDR_NONE is not defined. gmake[2]: *** [dbgPgConn.o] Error 1 This seems to be a known problem with Solaris10. I prepared a patch based on how the same issue is worked around in 'pgadmin/db/pgConn.cpp' and it is attached here. please feel free to comment/review the same. cheers Mayuresh Index: pgadmin/debugger/dbgPgConn.cpp =================================================================== --- pgadmin/debugger/dbgPgConn.cpp (revision 7390) +++ pgadmin/debugger/dbgPgConn.cpp (working copy) @@ -26,8 +26,13 @@ #include <arpa/inet.h> #include <netdb.h> #include <netinet/in.h> + +#ifndef INADDR_NONE +#define INADDR_NONE (-1) #endif +#endif + //////////////////////////////////////////////////////////////////////////////// // dbgPgConn constructors //
On Wed, Jul 9, 2008 at 12:42 PM, Mayuresh Nirhali <Mayuresh.Nirhali@sun.com> wrote: > Hello, > > While building pgadmin 1.8.4 on Solaris 10, I encountered following error. > > "./debugger/dbgPgConn.cpp", line 97: Error: INADDR_NONE is not defined. > gmake[2]: *** [dbgPgConn.o] Error 1 > > This seems to be a known problem with Solaris10. > I prepared a patch based on how the same issue is worked around in > 'pgadmin/db/pgConn.cpp' and it is attached here. > > please feel free to comment/review the same. That code hasn't been a problem for Solaris packages built in the past - do you know what has changed? Zdenek; have you run into this before? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Hello, OpenSolaris has IPADDR_NONE defined in netinet/in.h. but Solaris 10 does not. I believe the previous builds for pgAdmin 1.8.4 for were only done for OpenSolaris. Could you please confirm, zdenek ? Mayuresh Dave Page wrote: > On Wed, Jul 9, 2008 at 12:42 PM, Mayuresh Nirhali > <Mayuresh.Nirhali@sun.com> wrote: > >> Hello, >> >> While building pgadmin 1.8.4 on Solaris 10, I encountered following error. >> >> "./debugger/dbgPgConn.cpp", line 97: Error: INADDR_NONE is not defined. >> gmake[2]: *** [dbgPgConn.o] Error 1 >> >> This seems to be a known problem with Solaris10. >> I prepared a patch based on how the same issue is worked around in >> 'pgadmin/db/pgConn.cpp' and it is attached here. >> >> please feel free to comment/review the same. >> > > That code hasn't been a problem for Solaris packages built in the past > - do you know what has changed? > > Zdenek; have you run into this before? > > >
Dave Page napsal(a): > On Wed, Jul 9, 2008 at 12:42 PM, Mayuresh Nirhali > <Mayuresh.Nirhali@sun.com> wrote: >> Hello, >> >> While building pgadmin 1.8.4 on Solaris 10, I encountered following error. >> >> "./debugger/dbgPgConn.cpp", line 97: Error: INADDR_NONE is not defined. >> gmake[2]: *** [dbgPgConn.o] Error 1 >> >> This seems to be a known problem with Solaris10. >> I prepared a patch based on how the same issue is worked around in >> 'pgadmin/db/pgConn.cpp' and it is attached here. >> >> please feel free to comment/review the same. > > That code hasn't been a problem for Solaris packages built in the past > - do you know what has changed? > > Zdenek; have you run into this before? > Hi Dave, I built pgadmin only on Nevada and I have never seen this. Latest version which we built on S10 was 1.6.3 and it works fine, but this is new feature in pgAdmin 1.8. INADDR_NONE is not in any standard. I found some CR http://bugs.opensolaris.org/view_bug.do?bug_id=6235070 http://bugs.opensolaris.org/view_bug.do?bug_id=4111648 And PHP bug: http://bugs.php.net/bug.php?id=30304&edit=1 POSIX http://www.opengroup.org/onlinepubs/009695399/functions/inet_addr.html http://www.opengroup.org/onlinepubs/009695399/basedefs/netinet/in.h.html It seems that it is defined now in latest Solaris 10 updates but not on Solaris 10FCS which we use for build. There are two possible solution. One is to use Mayuresh patch or second replace INADDR_NONE macro with -1 in the code. Zdenek
On Thu, Jul 10, 2008 at 9:25 AM, Zdenek Kotala <Zdenek.Kotala@sun.com> wrote: > It seems that it is defined now in latest Solaris 10 updates but not on > Solaris 10FCS which we use for build. There are two possible solution. One > is to use Mayuresh patch or second replace INADDR_NONE macro with -1 in the > code. Thanks Zdenek - I've applied Mayuresh's patch. Thanks Mayuresh! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com