Обсуждение: Patch for "Panel for Joins in the Graphic Query Builder"

Hi Ashesh

On Mon, Dec 1, 2008 at 10:41 AM, Ashesh D Vashi
<ashesh.vashi@enterprisedb.com> wrote:

> Modifications and addition are as follows:
> * Introduced couple of new classes for handling operations:
>   + gqbJoinsPanel - Panel for handling the joins in the tab - container for
>                     criteria, order & columns panels
>   + gqbJoinsPopUp - Pop up window, when selecting a column from the table
> list,
>                     derived from the gqbColsPopUp
>   + gqbGridJoinTable - Table for handling all the joins data. It handles
> three
>                        columns Source, Join-Type & Destination
> * Added new images gqbAdd.xpm & gqbRemove.xpm
> * Renamed wxRestrictionGrid to gqbCustomGrid as we're using the same Grid
> for
>   handling the criteria(s) and join(s) in the gqbCriteriaPanel and
> gqbJoinsPanel
>   respectively.
> * Added one operator [] in gqbArrayCollection for accessing the gqbObject
> object
>   directory (replacement/accessibility of the object at particular index
> will be
>   easy and fast).
> * Removed the context menu "Set Type" removed for join, as this operation
> will be
>   handled from the joins-panel now onwards.

Wow - that's a whole lot more code than I was expecting (and explains
why it took somewhat longer than I planned). What I meant, was that I
just wanted a replacement dialogue for the existing one. What you've
done is reimplement the join handling, in what I think is a *much*
nicer way :-)

The only issues I've seen while testing (on Windows), are:

- The Join label doesn't update on the diagram if you change the join
type unless you click on the drawing canvas afterwards.

- Selecting a join should select the corresponding row in the list.

- You are missing updates to include/images/module.mk and
include/gqb/module.mk. The images should also be added to the VC++
project file.

Nice work!

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Wow - that's a whole lot more code than I was expecting (and explains
why it took somewhat longer than I planned). What I meant, was that I
just wanted a replacement dialogue for the existing one. What you've

done is reimplement the join handling, in what I think is a *much*
nicer way :-)

The only issues I've seen while testing (on Windows), are:

- The Join label doesn't update on the diagram if you change the join
type unless you click on the drawing canvas afterwards.

- Selecting a join should select the corresponding row in the list.

- You are missing updates to include/images/module.mk and
include/gqb/module.mk. The images should also be added to the VC++
project file.

Hi,

On Tue, Dec 2, 2008 at 8:02 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:

> - The Join label doesn't update on the diagram if you change the join
> type unless you click on the drawing canvas afterwards.
>
> Done
> Only issue, I can see with the combobox within the Grid, is until you loose
> the focus
> (by either pressing return or moving to other cell), the value is not
> getting updated
> for that particular join

I don't see any difference on Windows - I still need to click on the
canvas before the label changes. Changing to a difference cell, or
hitting return doesn't help.

> - Selecting a join should select the corresponding row in the list.
>
> In fact, I implemented this feature on double click.
> Now onwards,
> * For single left click, row will be selected, but the "joins panel" will be
> activate.
> * For double left click, "Joins panel" will be selected and the
> corresponding row in
>    the list too.

That sounds good. It seems to work for a while, and then the row
highlighting stops working. It seemed to stop after I clicked on (but
didn't change the value) in one of the combos in the Join Type column.
To get it to work again, I have to close and re-open the query tool.

I spotted another minor issue - if I'm on the Joins tab, and I click
the Columns tab - the main tab set at the top switches to SQL Editor!


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

I don't see any difference on Windows - I still need to click on the
canvas before the label changes. Changing to a difference cell, or
hitting return doesn't help.

Hi Luis Ochoa,

Thanks for reviewing it.
>
> A good way to access the vector, but allowing the code to access
> directly the objects based on the index probably decrease the
> independece of the subyacent structured inside the collection. If I
> decided to change the vector for a hash map in a future this operator
> probably difficult the change by example, because now we have hard
> code access directly to the structure inside the collection.
For the same reason, I have not introduced the operator [] in
gqbCollection class, but in gqbArrayCollection.
I thought - as we are able to access & insert the objects using index.
Then, why not to have direct access to the object (easy for replacement
too).

In case if one of us decide to change the vector for a hash map in a
future, the insertion of an object at a particular index will also
create the same problem, which this operator will do.
What do you say?

Sorry if I misunderstood.

And thanks for the help.

Thanks & Regards,
Ashesh

- The Join label doesn't update on the diagram if you change the join
type unless you click on the drawing canvas afterwards.

Done
Only issue, I can see with the combobox within the Grid, is until you loose
the focus
(by either pressing return or moving to other cell), the value is not
getting updated
for that particular join   

I don't see any difference on Windows - I still need to click on the
canvas before the label changes. Changing to a difference cell, or
hitting return doesn't help. 

I spotted another minor issue - if I'm on the Joins tab, and I click
the Columns tab - the main tab set at the top switches to SQL Editor! 

Hi Ashesh

On Wed, Dec 3, 2008 at 10:42 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:

> I don't see any difference on Windows - I still need to click on the
> canvas before the label changes. Changing to a difference cell, or
> hitting return doesn't help.
>
>
> Done.

Yup - that looks good now.

> That sounds good. It seems to work for a while, and then the row
> highlighting stops working. It seemed to stop after I clicked on (but
> didn't change the value) in one of the combos in the Join Type column.
> To get it to work again, I have to close and re-open the query tool.

That is still broken however. Basically, clicking on a join just stops
highlighting the appropriate row. Double-clicking doesn't highlight
either, but it does still change the tab.

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

That sounds good. It seems to work for a while, and then the row
highlighting stops working. It seemed to stop after I clicked on (but
didn't change the value) in one of the combos in the Join Type column.
To get it to work again, I have to close and re-open the query tool.   

That is still broken however. Basically, clicking on a join just stops
highlighting the appropriate row. Double-clicking doesn't highlight
either, but it does still change the tab. 

On Thu, Dec 4, 2008 at 10:21 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the updated patch.
>
...
> This was happening, because I completely missed to call the gqbCustomGrid's
> Revert function.

Thanks - patch applied :-)


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Luis Ochoa a écrit :
> On Wed, Dec 3, 2008 at 6:13 AM, Ashesh Vashi
> <ashesh.vashi@enterprisedb.com <mailto:ashesh.vashi@enterprisedb.com>>
> wrote:
>
> (...)
> Now I publish a list of what I think will be useful functionalities on
> the GQB if someone desiree to contribute:
> 1. Add Subqueries, this probably requeries multiples tabs for query.
> 2. Add Support to composite types.
> 3. Add a new skin for the graphics probably with a scroll on right and
> showing always all the columns (fixed at top) but the other columns can
> be move up/down with the scrollbar (an option can allow to choose
> between this and old graphics). And each table have a minimize (shrink
> only to table title),restore and remove from query button just as a
> window in a graphical operative system.
> 4. Add Save/Load functionality (probably xml).
>

Ashesh and Luis,

Sorry for not being available to test and comment, I'm on holidays for
the week. I just had time to test Dave's commit. I'm really impressed by
the quality of the Graphical Query Builder. It's a really great addition
to pgAdmin.

Here are some more stuff to add:

5. Adding columns myself which could be the result of a function
(count(*) is the first one to pop on my mind, but user functions would
be great to... all I ask for is a simple textbox to enter what we want).

6. Adding a user function in the ordering tab.

Thanks again.

Regards.


--
Guillaume.
   http://www.postgresql.fr
   http://www.dalibo.com

(...)

By the way Ashesh as I notice you know the tool I'm going to make you some commentaries:

I have been thinking a way of adding the group by and having operators to the GQB to basically allow the user to create more complex queries, but I'm not sure about the correct user interface to do this task, I think that group by can be as the ordering tab and the having tab can be as the criteria tab. Do you have any suggestions?

And about the join panel as I told you I was thinking that if the user select one join should be an easy option to change the query type like a floating toolbar with button with the join types that will be show near the selected join. What do you think about this?

Luis Ochoa a écrit :

On Wed, Dec 3, 2008 at 6:13 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com <mailto:ashesh.vashi@enterprisedb.com>> wrote:

(...)
Now I publish a list of what I think will be useful functionalities on the GQB if someone desiree to contribute:
1. Add Subqueries, this probably requeries multiples tabs for query.

2. Add Support to composite types.
3. Add a new skin for the graphics probably with a scroll on right and showing always all the columns (fixed at top) but the other columns can be move up/down with the scrollbar (an option can allow to choose between this and old graphics). And each table have a minimize (shrink only to table title),restore and remove from query button just as a window in a graphical operative system.
4. Add Save/Load functionality (probably xml).

Ashesh and Luis,

Sorry for not being available to test and comment, I'm on holidays for the week. I just had time to test Dave's commit. I'm really impressed by the quality of the Graphical Query Builder. It's a really great addition to pgAdmin.

Here are some more stuff to add:

5. Adding columns myself which could be the result of a function (count(*) is the first one to pop on my mind, but user functions would be great to... all I ask for is a simple textbox to enter what we want).

6. Adding a user function in the ordering tab.