Обсуждение: Re: Listctrl sizing (Was: Server Status window work)
On Mon, Jan 5, 2009 at 2:12 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Dave Page a écrit : >> Can you post what you have please? >> > > Sure, no problem. The last patch I was working on is the one attached, > though it seems to work better on Mac than on the linux box... grmbl... The size of that patch to fix a listctrl that won't shrink scares me :-(. Having played around, it seems it's caused by our use of the generic listctrl on Mac (see http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/trunk/pgadmin3/pgadmin/pgAdmin3.cpp?rev=6723&r1=6718&r2=6723). If we use the native control, sizing works fine (though the bottom buttons on the dlgType panes get slightly obscured as they do now). I've asked an expert about this - hopefully we may get some answers. If not, I wonder if we can use the generic control selectively somehow, so we can avoid the problem cases the commit above fixes, and get the sizing right elsewhere. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Mon, Jan 5, 2009 at 2:12 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Dave Page a écrit : >>> Can you post what you have please? >>> >> Sure, no problem. The last patch I was working on is the one attached, >> though it seems to work better on Mac than on the linux box... grmbl... > > The size of that patch to fix a listctrl that won't shrink scares me > :-(. Having played around, it seems it's caused by our use of the > generic listctrl on Mac (see > http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/trunk/pgadmin3/pgadmin/pgAdmin3.cpp?rev=6723&r1=6718&r2=6723). > If we use the native control, sizing works fine (though the bottom > buttons on the dlgType panes get slightly obscured as they do now). > Buttons are hidden on the bottom? check the <style> tag, I think there's no border for the bottom. Replace wxTOP|wxLEFT|wxRIGHT with wxALL and it should be better. > I've asked an expert about this - hopefully we may get some answers. > If not, I wonder if we can use the generic control selectively > somehow, so we can avoid the problem cases the commit above fixes, and > get the sizing right elsewhere. > Could be interesting. Thanks for looking at this. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Tue, Jan 6, 2009 at 7:58 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Buttons are hidden on the bottom? check the <style> tag, I think there's > no border for the bottom. Replace wxTOP|wxLEFT|wxRIGHT with wxALL and it > should be better. That got it - thanks. I also fixed the layout; one layout had the buttons on the bottom left, the other on the bottom right. >> I've asked an expert about this - hopefully we may get some answers. >> If not, I wonder if we can use the generic control selectively >> somehow, so we can avoid the problem cases the commit above fixes, and >> get the sizing right elsewhere. >> > > Could be interesting. > > Thanks for looking at this. Np. Working up a test case now... -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
On Tue, Jan 6, 2009 at 8:21 PM, Dave Page <dpage@pgadmin.org> wrote: >>> I've asked an expert about this - hopefully we may get some answers. >>> If not, I wonder if we can use the generic control selectively >>> somehow, so we can avoid the problem cases the commit above fixes, and >>> get the sizing right elsewhere. >>> >> >> Could be interesting. >> >> Thanks for looking at this. > > Np. Working up a test case now... Whilst we're waiting on that - how's the attached for a crazy patch? Seems to work... -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com .
Вложения
Dave Page a écrit : > On Tue, Jan 6, 2009 at 8:21 PM, Dave Page <dpage@pgadmin.org> wrote: >>>> I've asked an expert about this - hopefully we may get some answers. >>>> If not, I wonder if we can use the generic control selectively >>>> somehow, so we can avoid the problem cases the commit above fixes, and >>>> get the sizing right elsewhere. >>>> >>> Could be interesting. >>> >>> Thanks for looking at this. >> Np. Working up a test case now... > > Whilst we're waiting on that - how's the attached for a crazy patch? > Seems to work... > Why crazy? Works on Mac OS X and Linux. I didn't check on Windows yet, but it seems the more stable plateform (I mean, to the wxWidgets code). -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Wed, Jan 7, 2009 at 10:36 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Why crazy? Just in the way it works, by repeatedly toggling the 'always use generic' flag to ensure we don't always use it. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com