Обсуждение: pgAdmin and Slony

Dave,

* pgAdmin code not up-to-date with latest Slony versions.

Attached is a patch for updating pgAdmin code for Slony latest version.

--
Regards,
Sachin Srivastava
www.enterprisedb.com

On Thu, Sep 3, 2009 at 8:20 AM, Sachin
Srivastava<sachin.srivastava@enterprisedb.com> wrote:
> Dave,
>
> * pgAdmin code not up-to-date with latest Slony versions.
>
> Attached is a patch for updating pgAdmin code for Slony latest version.

OK, quick eyeball review:

- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString &series, long minor)

- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Dave,

> - bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)
>
> should be:
>
> bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)
>
Done.
> - Just reading the patch, it looks like we never try to load xxid*.sql
> any more. That's surely wrong?
>
Yes. Attached is an updated patch.
>
>


--
Regards,
Sachin Srivastava
www.enterprisedb.com

On Thu, Sep 3, 2009 at 2:08 PM, Sachin
Srivastava<sachin.srivastava@enterprisedb.com> wrote:

Dave,

- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)

Done.

- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?

Yes. Attached is an updated patch.

Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
can you review it as well please?

On Thu, Sep 3, 2009 at 2:08 PM, Sachin
Srivastava<sachin.srivastava@enterprisedb.com> wrote:
> Dave,
>
>> - bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)
>>
>> should be:
>>
>> bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)
>>
>
> Done.
>>
>> - Just reading the patch, it looks like we never try to load xxid*.sql
>> any more. That's surely wrong?
>>
>
> Yes. Attached is an updated patch.

Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
can you review it as well please?

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Ashesh - did you get a chance to test this?

On Thu, Sep 3, 2009 at 2:37 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Looks good to me..
> Though not tested..
> I will be able to test it tomorrow.
>
> Dave Page wrote:
>
> On Thu, Sep 3, 2009 at 2:08 PM, Sachin
> Srivastava<sachin.srivastava@enterprisedb.com> wrote:
>
> Dave,
>
> - bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)
>
> should be:
>
> bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)
>
> Done.
>
> - Just reading the patch, it looks like we never try to load xxid*.sql
> any more. That's surely wrong?
>
> Yes. Attached is an updated patch.
>
> Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
> can you review it as well please?
>
>



--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Ashesh - did you get a chance to test this?

On Thu, Sep 3, 2009 at 2:37 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote: 

Looks good to me..
Though not tested..
I will be able to test it tomorrow.

Dave Page wrote:

On Thu, Sep 3, 2009 at 2:08 PM, Sachin
Srivastava<sachin.srivastava@enterprisedb.com> wrote:

Dave,

- bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)

should be:

bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)

Done.

- Just reading the patch, it looks like we never try to load xxid*.sql
any more. That's surely wrong?

Yes. Attached is an updated patch.

Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
can you review it as well please?

   

On Wed, Sep 30, 2009 at 2:03 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
>
> I really did not get a chance to test this one.
> But, when I reviewed it at that time, I looked good to me.

OK, I'll try to spend some time on it today or tomorrow.


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com