Обсуждение: Ticket #8: Colour coding for the backend lines in the server status window

Hi,

Here is partial patch to have colored lines for backends. I followed Dave's
proposition:

Say green for running OK, orange for running, but with the query time being
past a configurable limit, blue for idle, and red when waiting for a lock etc.

The patch is not complete because of these:

 * Shouldn't the colors be customizable? I can add a tab on frmOptions.

 * Where do I put the configuration of the time limit? on a toolbar of the
   frmStatus window, or in the frmOptions dialog?

Comments welcomed :)

Thanks.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

On Tue, Sep 15, 2009 at 10:18 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> Here is partial patch to have colored lines for backends. I followed Dave's
> proposition:
>
> Say green for running OK, orange for running, but with the query time being
> past a configurable limit, blue for idle, and red when waiting for a lock etc.

Looks pretty straightforward.

> The patch is not complete because of these:
>
>  * Shouldn't the colors be customizable? I can add a tab on frmOptions.

I think so.

>  * Where do I put the configuration of the time limit? on a toolbar of the
>   frmStatus window, or in the frmOptions dialog?

I think frmStatus. The time limits of interest may be different on
your DW server than your OLTP system, so it would make sense to allow
control on the window itself. I think a setting against the server is
probably going a little too far, but if you can find a nice interface
for it, I could be persuaded...

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

On Wed, Sep 16, 2009 at 10:22, Dave Page <dpage@pgadmin.org> wrote:
> On Tue, Sep 15, 2009 at 10:18 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Hi,
>>
>> Here is partial patch to have colored lines for backends. I followed Dave's
>> proposition:
>>
>> Say green for running OK, orange for running, but with the query time being
>> past a configurable limit, blue for idle, and red when waiting for a lock etc.
>
> Looks pretty straightforward.
>
>> The patch is not complete because of these:
>>
>>  * Shouldn't the colors be customizable? I can add a tab on frmOptions.
>
> I think so.

Agreed.

I'd also think the default should be "not so colorful". Meaning the
one that will show the most (in most cases I've looked, that's idle)
should be the default gray color. Then the colors you suggested for
the rest (or maybe blue for running, because it's often a "softer"
color than green).


>>  * Where do I put the configuration of the time limit? on a toolbar of the
>>   frmStatus window, or in the frmOptions dialog?
>
> I think frmStatus. The time limits of interest may be different on
> your DW server than your OLTP system, so it would make sense to allow
> control on the window itself. I think a setting against the server is
> probably going a little too far, but if you can find a nice interface
> for it, I could be persuaded...

Actually, for starters I think we'd be fine even without the time
limit feature at all :-)

Now, if you can make the table sortable by "query start time", *that*
would be useful :-)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Le mercredi 16 septembre 2009 à 10:31:58, Magnus Hagander a écrit :
> On Wed, Sep 16, 2009 at 10:22, Dave Page <dpage@pgadmin.org> wrote:
> > On Tue, Sep 15, 2009 at 10:18 PM, Guillaume Lelarge
> > [...]
> >> The patch is not complete because of these:
> >>
> >>  * Shouldn't the colors be customizable? I can add a tab on frmOptions.
> >
> > I think so.
>
> Agreed.
>

So do I. This new patch adds a tab on frmOptions to allow the colors' change.

> I'd also think the default should be "not so colorful". Meaning the
> one that will show the most (in most cases I've looked, that's idle)
> should be the default gray color. Then the colors you suggested for
> the rest (or maybe blue for running, because it's often a "softer"
> color than green).
>

Changed. Not sure it's really better.

> >>  * Where do I put the configuration of the time limit? on a toolbar of
> >> the frmStatus window, or in the frmOptions dialog?
> >
> > I think frmStatus. The time limits of interest may be different on
> > your DW server than your OLTP system, so it would make sense to allow
> > control on the window itself. I think a setting against the server is
> > probably going a little too far, but if you can find a nice interface
> > for it, I could be persuaded...
>
> Actually, for starters I think we'd be fine even without the time
> limit feature at all :-)
>

I didn't add the configuration of the time limit. I will probably work on this
after this patch. I'm not sure of the UI. I think I should add it to the
toolbar, but there's already a time configuration (refresh delay).

> Now, if you can make the table sortable by "query start time", *that*
> would be useful :-)
>

It would be useful for every table pgAdmin displays (statistics come to my
mind quite instantly).

I attach the new patch.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Le dimanche 20 septembre 2009 à 00:47:58, Guillaume Lelarge a écrit :
> Le mercredi 16 septembre 2009 à 10:31:58, Magnus Hagander a écrit :
> > On Wed, Sep 16, 2009 at 10:22, Dave Page <dpage@pgadmin.org> wrote:
> > > On Tue, Sep 15, 2009 at 10:18 PM, Guillaume Lelarge
> > > [...]
>
> I attach the new patch.
>

No comments on this patch? can I apply?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

On Thu, Sep 24, 2009 at 6:23 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le dimanche 20 septembre 2009 à 00:47:58, Guillaume Lelarge a écrit :
>> Le mercredi 16 septembre 2009 à 10:31:58, Magnus Hagander a écrit :
>> > On Wed, Sep 16, 2009 at 10:22, Dave Page <dpage@pgadmin.org> wrote:
>> > > On Tue, Sep 15, 2009 at 10:18 PM, Guillaume Lelarge
>> > > [...]
>>
>> I attach the new patch.
>>
>
> No comments on this patch? can I apply?

If you're happy with it.

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Le jeudi 24 septembre 2009 à 20:47:45, Dave Page a écrit :
> On Thu, Sep 24, 2009 at 6:23 PM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Le dimanche 20 septembre 2009 à 00:47:58, Guillaume Lelarge a écrit :
> >> Le mercredi 16 septembre 2009 à 10:31:58, Magnus Hagander a écrit :
> >> > On Wed, Sep 16, 2009 at 10:22, Dave Page <dpage@pgadmin.org> wrote:
> >> > > On Tue, Sep 15, 2009 at 10:18 PM, Guillaume Lelarge
> >> > > [...]
> >>
> >> I attach the new patch.
> >
> > No comments on this patch? can I apply?
>
> If you're happy with it.
>

Done, thanks.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com