Обсуждение: pgAdmin III commit: Fix copy bug in the edit grid
Fix copy bug in the edit grid If you select only a part of the text in a cell, and try to copy it, it really copies all the cell. This patch makes sure that only the selected text is copied. Report from Mauro Bertoli. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=267c594ae6663becb29de3955f94d37d7705fcfb Modified Files -------------- CHANGELOG | 2 ++ pgadmin/frm/frmEditGrid.cpp | 13 ++++++++++++- 2 files changed, 14 insertions(+), 1 deletions(-)
seem that this commit broke ability to copy whole query result from result grid in query tool. result of git bisect: 267c594ae6663becb29de3955f94d37d7705fcfb is the first bad commit commit 267c594ae6663becb29de3955f94d37d7705fcfb Author: Guillaume Lelarge <guillaume@lelarge.info> Date: Wed Dec 22 00:04:54 2010 +0100 Fix copy bug in the edit grid If you select only a part of the text in a cell, and try to copy it, it really copies all the cell. This patch makes sure that only the selected text is copied. Report from Mauro Bertoli. :100644 100644 f0cbd7e9923010078a30a82e9d51a5147fb28c34 c37af2b9f58c3cfd12f57365e5e7045d46b517c2 M CHANGELOG :040000 040000 e4d8821d61d19f34e152e9e743f6d1ffbcc3ce43 118f5b08516ca7837cf5748e6d1071f31d7e1da1 M pgadmin 2010/12/22 Guillaume Lelarge <guillaume@lelarge.info>: > Fix copy bug in the edit grid > > If you select only a part of the text in a cell, and try to copy it, it really > copies all the cell. This patch makes sure that only the selected text is > copied. > > Report from Mauro Bertoli. > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=267c594ae6663becb29de3955f94d37d7705fcfb > > Modified Files > -------------- > CHANGELOG | 2 ++ > pgadmin/frm/frmEditGrid.cpp | 13 ++++++++++++- > 2 files changed, 14 insertions(+), 1 deletions(-) > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >
Le 21/01/2011 15:41, Timon a écrit : > seem that this commit broke ability to copy whole query result from > result grid in query tool. > Sorry for not answering sooner. I just tried and it seems to work right to me. I don't see any issue with copy and paste in the query tool. -- Guillaume http://www.postgresql.fr http://dalibo.com
just tested again with latest git version, same problem reproduce steps: 1. open query tool 2. select something 3. try to copy results from result grid using ctrl+c or main menu for me step 3 does nothing. watch attachment may be this is a problem of wxWidgets, I don't know, but before 267c594ae6663becb29de3955f94d37d7705fcfb commit everything was fine. my system fedora 14: wxGTK-2.8.11-3.fc14.x86_64 2011/1/28 Guillaume Lelarge <guillaume@lelarge.info>: > Le 21/01/2011 15:41, Timon a écrit : >> seem that this commit broke ability to copy whole query result from >> result grid in query tool. >> > > Sorry for not answering sooner. I just tried and it seems to work right > to me. I don't see any issue with copy and paste in the query tool. > > > -- > Guillaume > http://www.postgresql.fr > http://dalibo.com > -- All bugs reserved
Вложения
Le 28/01/2011 08:55, Timon a écrit : > just tested again with latest git version, same problem > reproduce steps: > 1. open query tool > 2. select something > 3. try to copy results from result grid using ctrl+c or main menu > for me step 3 does nothing. watch attachment > > may be this is a problem of wxWidgets, I don't know, but before > 267c594ae6663becb29de3955f94d37d7705fcfb commit everything was fine. > Sorry, still works for me. > my system > fedora 14: > wxGTK-2.8.11-3.fc14.x86_64 > I'm on Ubuntu and have wxGTK 2.8.11+. -- Guillaume http://www.postgresql.fr http://dalibo.com