Обсуждение: pgAdmin III commit: Quick fix for a registry datatype issue on Windows,
Quick fix for a registry datatype issue on Windows, introduced by the wx 2.9 patch. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8f9c483868c587cc2ac6332a927338426ae9836c Modified Files -------------- pgadmin/frm/frmHint.cpp | 2 +- pgadmin/include/utils/sysSettings.h | 1 + pgadmin/utils/sysSettings.cpp | 6 ++++++ 3 files changed, 8 insertions(+), 1 deletions(-)
Re: pgAdmin III commit: Quick fix for a registry datatype issue on Windows,
От
Peter Geoghegan
Дата:
I take it that you don't see any C4800 warnings on this, because the overload doesn't cause the same problems that we saw with ctlListView? -- Regards, Peter Geoghegan
On Tue, Feb 1, 2011 at 5:34 PM, Peter Geoghegan <peter.geoghegan86@gmail.com> wrote: > I take it that you don't see any C4800 warnings on this, because the > overload doesn't cause the same problems that we saw with ctlListView? Only the one I fixed in that commit in frmHint.cpp. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
This commit 8f9c483868c587cc2ac6332a927338426ae9836c broke an ability to suppress different guru hints. reproduce steps. 1. remove [Hints] from .pgadmin3 2. run pgadmin3 3. open connection to server 4. The windows "Guru Hint - Server instrumentation not installed" should appear 5. check "Do not show this hint again" 6. press ok button 7. close pgadmin3 8. run pgadmin3 again and connect to server On my system I see "Guru Hint - Server instrumentation not installed" window again, but I checked "Do not show this hint again" in step 4. before this commit in [Hints] section in .pgadmin3: [Hints] instrumentation=Suppress but after this commit [Hints] instrumentation=true 2011/2/1 Dave Page <dpage@pgadmin.org>: > Quick fix for a registry datatype issue on Windows, introduced by > the wx 2.9 patch. > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8f9c483868c587cc2ac6332a927338426ae9836c > > Modified Files > -------------- > pgadmin/frm/frmHint.cpp | 2 +- > pgadmin/include/utils/sysSettings.h | 1 + > pgadmin/utils/sysSettings.cpp | 6 ++++++ > 3 files changed, 8 insertions(+), 1 deletions(-) > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- All bugs reserved
Thanks - I've committed a fix for this, that hopefully didn't break anything else! On Tue, Feb 15, 2011 at 10:40 AM, Timon <timosha@gmail.com> wrote: > This commit 8f9c483868c587cc2ac6332a927338426ae9836c broke an ability > to suppress different guru hints. > > reproduce steps. > 1. remove [Hints] from .pgadmin3 > 2. run pgadmin3 > 3. open connection to server > 4. The windows "Guru Hint - Server instrumentation not installed" should appear > 5. check "Do not show this hint again" > 6. press ok button > 7. close pgadmin3 > 8. run pgadmin3 again and connect to server > > On my system I see "Guru Hint - Server instrumentation not installed" > window again, but I checked "Do not show this hint again" in step 4. > > before this commit in [Hints] section in .pgadmin3: > > [Hints] > instrumentation=Suppress > > but after this commit > > [Hints] > instrumentation=true > > 2011/2/1 Dave Page <dpage@pgadmin.org>: >> Quick fix for a registry datatype issue on Windows, introduced by >> the wx 2.9 patch. >> >> Branch >> ------ >> master >> >> Details >> ------- >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8f9c483868c587cc2ac6332a927338426ae9836c >> >> Modified Files >> -------------- >> pgadmin/frm/frmHint.cpp | 2 +- >> pgadmin/include/utils/sysSettings.h | 1 + >> pgadmin/utils/sysSettings.cpp | 6 ++++++ >> 3 files changed, 8 insertions(+), 1 deletions(-) >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> > > > > -- > All bugs reserved > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company