Обсуждение: pgAdmin III commit: Handle hostaddr connection parameter
Handle hostaddr connection parameter Implements ticket #312. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=263ca64ec4579d69615a983517f1e93ca6c59a76 Modified Files -------------- CHANGELOG | 1 + pgadmin/db/pgConn.cpp | 10 ++++++++-- pgadmin/dlg/dlgSelectConnection.cpp | 4 ++-- pgadmin/dlg/dlgServer.cpp | 9 ++++++++- pgadmin/frm/frmMain.cpp | 1 + pgadmin/frm/frmStatus.cpp | 6 ++++-- pgadmin/include/db/pgConn.h | 8 ++++++-- pgadmin/include/schema/pgServer.h | 12 ++++++++++-- pgadmin/pgscript/pgsApplication.cpp | 2 +- pgadmin/schema/pgRole.cpp | 1 + pgadmin/schema/pgServer.cpp | 21 ++++++++++++--------- pgadmin/ui/dlgServer.xrc | 14 +++++++++++++- 12 files changed, 67 insertions(+), 22 deletions(-)
I'm not happy with the way this is done (from the UI perspective). We now have two fields on the server dialogue, one labelled "Host" and one labelled "Host Address". It's not at all obvious to the user when one should be used over the other. To avoid confusion, I think we should put the Host Address field on the Advanced Tab. Also, I notice the documentation hasn't been updated for this, or any of the other recent additions of controls to this dialogue. Can you fix that please (the text at least - we can do the screenshots in one go later)? On Mon, Apr 11, 2011 at 6:11 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Handle hostaddr connection parameter > > Implements ticket #312. > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=263ca64ec4579d69615a983517f1e93ca6c59a76 > > Modified Files > -------------- > CHANGELOG | 1 + > pgadmin/db/pgConn.cpp | 10 ++++++++-- > pgadmin/dlg/dlgSelectConnection.cpp | 4 ++-- > pgadmin/dlg/dlgServer.cpp | 9 ++++++++- > pgadmin/frm/frmMain.cpp | 1 + > pgadmin/frm/frmStatus.cpp | 6 ++++-- > pgadmin/include/db/pgConn.h | 8 ++++++-- > pgadmin/include/schema/pgServer.h | 12 ++++++++++-- > pgadmin/pgscript/pgsApplication.cpp | 2 +- > pgadmin/schema/pgRole.cpp | 1 + > pgadmin/schema/pgServer.cpp | 21 ++++++++++++--------- > pgadmin/ui/dlgServer.xrc | 14 +++++++++++++- > 12 files changed, 67 insertions(+), 22 deletions(-) > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 12/04/2011 17:36, Dave Page a écrit : > I'm not happy with the way this is done (from the UI perspective). We > now have two fields on the server dialogue, one labelled "Host" and > one labelled "Host Address". It's not at all obvious to the user when > one should be used over the other. > > To avoid confusion, I think we should put the Host Address field on > the Advanced Tab. > Done. > Also, I notice the documentation hasn't been updated for this, or any > of the other recent additions of controls to this dialogue. Can you > fix that please (the text at least - we can do the screenshots in one > go later)? > Maybe it would be a great time to bring back my documentation work I did a few months earlier. We actually have some months to work on this stuff. -- Guillaume http://www.postgresql.fr http://dalibo.com
Le 12/04/2011 21:44, Guillaume Lelarge a écrit : > Le 12/04/2011 17:36, Dave Page a écrit : >> I'm not happy with the way this is done (from the UI perspective). We >> now have two fields on the server dialogue, one labelled "Host" and >> one labelled "Host Address". It's not at all obvious to the user when >> one should be used over the other. >> >> To avoid confusion, I think we should put the Host Address field on >> the Advanced Tab. >> > > Done. > >> Also, I notice the documentation hasn't been updated for this, or any >> of the other recent additions of controls to this dialogue. Can you >> fix that please (the text at least - we can do the screenshots in one >> go later)? >> > > Maybe it would be a great time to bring back my documentation work I did > a few months earlier. We actually have some months to work on this stuff. > Dave, are you OK that I work on the documentation for 1.14 or do you think it is already too late? -- Guillaume http://www.postgresql.fr http://dalibo.com
On Thu, Apr 14, 2011 at 8:33 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 12/04/2011 21:44, Guillaume Lelarge a écrit : >> Le 12/04/2011 17:36, Dave Page a écrit : >>> I'm not happy with the way this is done (from the UI perspective). We >>> now have two fields on the server dialogue, one labelled "Host" and >>> one labelled "Host Address". It's not at all obvious to the user when >>> one should be used over the other. >>> >>> To avoid confusion, I think we should put the Host Address field on >>> the Advanced Tab. >>> >> >> Done. >> >>> Also, I notice the documentation hasn't been updated for this, or any >>> of the other recent additions of controls to this dialogue. Can you >>> fix that please (the text at least - we can do the screenshots in one >>> go later)? >>> >> >> Maybe it would be a great time to bring back my documentation work I did >> a few months earlier. We actually have some months to work on this stuff. >> > > Dave, are you OK that I work on the documentation for 1.14 or do you > think it is already too late? I think it's a bit late really. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 14/04/2011 21:35, Dave Page a écrit : > On Thu, Apr 14, 2011 at 8:33 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 12/04/2011 21:44, Guillaume Lelarge a écrit : >>> Le 12/04/2011 17:36, Dave Page a écrit : >>>> I'm not happy with the way this is done (from the UI perspective). We >>>> now have two fields on the server dialogue, one labelled "Host" and >>>> one labelled "Host Address". It's not at all obvious to the user when >>>> one should be used over the other. >>>> >>>> To avoid confusion, I think we should put the Host Address field on >>>> the Advanced Tab. >>>> >>> >>> Done. >>> >>>> Also, I notice the documentation hasn't been updated for this, or any >>>> of the other recent additions of controls to this dialogue. Can you >>>> fix that please (the text at least - we can do the screenshots in one >>>> go later)? >>>> >>> >>> Maybe it would be a great time to bring back my documentation work I did >>> a few months earlier. We actually have some months to work on this stuff. >>> >> >> Dave, are you OK that I work on the documentation for 1.14 or do you >> think it is already too late? > > I think it's a bit late really. > OK. Well, I'll focus on testing and debugging then :) -- Guillaume http://www.postgresql.fr http://dalibo.com