Обсуждение: pgAdmin III commit: Another wxWidgets 2.9 assert

Поиск
Список
Период
Сортировка

pgAdmin III commit: Another wxWidgets 2.9 assert

От
Guillaume Lelarge
Дата:
Another wxWidgets 2.9 assert

Report from Colin Beckingham.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a6b2ca85d9b64816b2501ab92d32c26d85952675

Modified Files
--------------
pgadmin/frm/frmQuery.cpp |    4 ----
1 files changed, 0 insertions(+), 4 deletions(-)


Re: pgAdmin III commit: Another wxWidgets 2.9 assert

От
Akshay Joshi
Дата:
Hi Guillaume 

In the below commit you have removed the wxWidget's version check that I have added to avoid the linker error on Windows. By removing that I am again getting linker error. Attached is the patch which fix the linker error as well as the assert that Colin has faced. 

Please review it and If looks good please commit it.


On Wed, Mar 7, 2012 at 7:39 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
Another wxWidgets 2.9 assert

Report from Colin Beckingham.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=a6b2ca85d9b64816b2501ab92d32c26d85952675

Modified Files
--------------
pgadmin/frm/frmQuery.cpp |    4 ----
1 files changed, 0 insertions(+), 4 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers



--
Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246

Вложения

Re: pgAdmin III commit: Another wxWidgets 2.9 assert

От
Guillaume Lelarge
Дата:
On Fri, 2012-03-09 at 15:16 +0530, Akshay Joshi wrote:
> Hi Guillaume
>
>
> In the below commit you have removed the wxWidget's version check that
> I have added to avoid the linker error on Windows. By removing that I
> am again getting linker error. Attached is the patch which fix the
> linker error as well as the assert that Colin has faced.
>
>
> Please review it and If looks good please commit it.
>

Thanks, it works AFAICT, so I pushed your patch.


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com