Обсуждение: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl

Hi,

The SqlFieldControl is setting default height for textarea, which is not needed.

It should expand as needed as similar in SqlTabControl.

Please find the attached patch, review it.

Thanks

Surinder Kumar

Hi,

More specifically to the issue.

I am using SqlFieldControl in View for Definition Field which takes default height of 300px which is set by Control as default height. but as per dave's suggestion on thread

http://www.postgresql.org/message-id/CA+OCxozN++8sFqJwJZ5QSFBxa7p-47apohOLtSotPBK6N5vUJA@mail.gmail.com

"The Definition box on the View dialogue should start at a single

line and expand as needed - see the Function dialogue".

If user still need some height for control, It can be specified in extraclasses[] parameter which will apply to the specific field.

On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi,

The SqlFieldControl is setting default height for textarea, which is not needed.

It should expand as needed as similar in SqlTabControl.

Please find the attached patch, review it.

Thanks

Surinder Kumar