Обсуждение: [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

Поиск
Список
Период
Сортировка

[pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

От
Akshay Joshi
Дата:
Hi All 

I have implemented the sql auto complete feature for Query Tool in pgAdmin4. To achieve this I have analyzed the code of "pgcli (http://pgcli.com/)" and also used some part of the code "(https://github.com/dbcli/pgcli )" with our own modification. 

"pgcli" buffers all the data(databases, tables, functions etc...) at once while connecting to the database, but we can't do that, so when user press "Ctrl+Space" in the Query Tool we will fetch the data and display the suggestions accordingly.

Attached is the patch file. Please review it and let me know the review comments (if any). 

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

Re: [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

От
Akshay Joshi
Дата:
Just to update Multi line support is not there right now.

On Wed, May 18, 2016 at 8:09 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have implemented the sql auto complete feature for Query Tool in pgAdmin4. To achieve this I have analyzed the code of "pgcli (http://pgcli.com/)" and also used some part of the code "(https://github.com/dbcli/pgcli )" with our own modification. 

"pgcli" buffers all the data(databases, tables, functions etc...) at once while connecting to the database, but we can't do that, so when user press "Ctrl+Space" in the Query Tool we will fetch the data and display the suggestions accordingly.

Attached is the patch file. Please review it and let me know the review comments (if any). 

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

От
Akshay Joshi
Дата:
Hi All

Today I have added support for multi line and also improve searching logic. Please ignore the last patch.
Attached is the new patch. Please review it and let me know the review comments (if any). 

On Wed, May 18, 2016 at 8:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Just to update Multi line support is not there right now.

On Wed, May 18, 2016 at 8:09 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have implemented the sql auto complete feature for Query Tool in pgAdmin4. To achieve this I have analyzed the code of "pgcli (http://pgcli.com/)" and also used some part of the code "(https://github.com/dbcli/pgcli )" with our own modification. 

"pgcli" buffers all the data(databases, tables, functions etc...) at once while connecting to the database, but we can't do that, so when user press "Ctrl+Space" in the Query Tool we will fetch the data and display the suggestions accordingly.

Attached is the patch file. Please review it and let me know the review comments (if any). 

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

Re: [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

От
Ashesh Vashi
Дата:
Thanks - committed with some minor tweaks.

In order to load a directory as python module, we should have at least empty __init__.py file exists in that directory.
Also, I've changed the keywords in capital letters.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Thu, May 19, 2016 at 4:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All

Today I have added support for multi line and also improve searching logic. Please ignore the last patch.
Attached is the new patch. Please review it and let me know the review comments (if any). 

On Wed, May 18, 2016 at 8:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Just to update Multi line support is not there right now.

On Wed, May 18, 2016 at 8:09 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

I have implemented the sql auto complete feature for Query Tool in pgAdmin4. To achieve this I have analyzed the code of "pgcli (http://pgcli.com/)" and also used some part of the code "(https://github.com/dbcli/pgcli )" with our own modification. 

"pgcli" buffers all the data(databases, tables, functions etc...) at once while connecting to the database, but we can't do that, so when user press "Ctrl+Space" in the Query Tool we will fetch the data and display the suggestions accordingly.

Attached is the patch file. Please review it and let me know the review comments (if any). 

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers