Обсуждение: fix for RM1210 [pgadmin4]
Вложения
Hi Harshal,
On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Hi,
Issue: For column node it was showing wrong sql in sql tab
<html><head></head><body>-- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer;</body></html>
Fix: I have changed response to ajax response while returning SQL for column node.
--
Harshal Dhumal
Software Engineer
On Fri, Jun 3, 2016 at 12:52 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,Can you please describe the issue, and root cause, and how did you fix it?On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Issue: For column node it was showing wrong sql in sql tab<html><head></head><body>-- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer;</body></html>Fix: I have changed response to ajax response while returning SQL for column node.
Hi Harshal,
Can you please introduce a function in pgadmin.utils regarding that, which set the proper mime-type for this purpose, and make sure - we do use that for each and every nodes, for sql and modified_sql methods?
--Harshal DhumalSoftware EngineerOn Fri, Jun 3, 2016 at 12:52 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Harshal,Can you please describe the issue, and root cause, and how did you fix it?On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Hi Ashesh,
I have used 'ajax_response' utility function (alias to make_response pdadmin utility function) which has mime-type set to "text/json" which is correct I guess in this case.--
Harshal Dhumal
Software Engineer
On Fri, Jun 3, 2016 at 1:04 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Issue: For column node it was showing wrong sql in sql tab<html><head></head><body>-- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer;</body></html>Fix: I have changed response to ajax response while returning SQL for column node.Hi Harshal,Can you please introduce a function in pgadmin.utils regarding that, which set the proper mime-type for this purpose, and make sure - we do use that for each and every nodes, for sql and modified_sql methods?--Harshal DhumalSoftware EngineerOn Fri, Jun 3, 2016 at 12:52 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Harshal,Can you please describe the issue, and root cause, and how did you fix it?On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Fri, Jun 3, 2016 at 1:13 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Also I have check all other node to check if all of them are using correct function while returning sql.Hi Ashesh,I have used 'ajax_response' utility function (alias to make_response pdadmin utility function) which has mime-type set to "text/json" which is correct I guess in this case.
Ok.
Thanks - committed!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
--Harshal DhumalSoftware EngineerOn Fri, Jun 3, 2016 at 1:04 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,Issue: For column node it was showing wrong sql in sql tab<html><head></head><body>-- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer;</body></html>Fix: I have changed response to ajax response while returning SQL for column node.Hi Harshal,Can you please introduce a function in pgadmin.utils regarding that, which set the proper mime-type for this purpose, and make sure - we do use that for each and every nodes, for sql and modified_sql methods?--Harshal DhumalSoftware EngineerOn Fri, Jun 3, 2016 at 12:52 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Harshal,Can you please describe the issue, and root cause, and how did you fix it?On Fri, Jun 3, 2016 at 12:48 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers