Обсуждение: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

Поиск
Список
Период
Сортировка

[pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

От
Surinder Kumar
Дата:
Hi

In Dashboard, the ajax calls to render data grid should only made, if dashboard panel is active.
Currently it make ajax calls even if other panels like properties, sql are active.

Please find attached patch and review.

Thanks,
Surinder Kumar
Вложения

Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

От
Dave Page
Дата:
Won't this result in incorrect graphs? I.e. chunks of data being missing (but not obviously so)?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 13 Jul 2016, at 07:47, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

In Dashboard, the ajax calls to render data grid should only made, if dashboard panel is active.
Currently it make ajax calls even if other panels like properties, sql are active.

Please find attached patch and review.

Thanks,
Surinder Kumar
<dashboard_render_if_panel_is_opened.patch>

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

От
Surinder Kumar
Дата:
On Wed, Jul 13, 2016 at 12:32 PM, Dave Page <dpage@pgadmin.org> wrote:
Won't this result in incorrect graphs? I.e. chunks of data being missing (but not obviously so)?
 Oh I see.. It might result in incorrect graphs..
Please ignore the patch.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 13 Jul 2016, at 07:47, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

In Dashboard, the ajax calls to render data grid should only made, if dashboard panel is active.
Currently it make ajax calls even if other panels like properties, sql are active.

Please find attached patch and review.

Thanks,
Surinder Kumar
<dashboard_render_if_panel_is_opened.patch>

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers