Обсуждение: [Patch][pgAdmin4]: RM1442 - Table column data is incomplete for columns having more character lengths

Hi

On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Issue:
> The table column data is incomplete for columns having more character
> lengths.
>
> Solution:
> Extends Backgrid.Cell and add 'mouseover' event. On mouse over, check if
> cell content is larger than the cell width, then add tooltip to the column
> by setting cell content in the title attribute.
>
> Please find attached patch and review.

This has been taken care of in Murtuza's patch to move to SlickGrid.
Please check with him to ensure you've got the best solution between
both your patches. I won't commit this.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Aug 18, 2016 9:42 PM, "Dave Page" <dpage@pgadmin.org> wrote:
>
> Hi
>
> On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
> > Hi
> >
> > Issue:
> > The table column data is incomplete for columns having more character
> > lengths.
> >
> > Solution:
> > Extends Backgrid.Cell and add 'mouseover' event. On mouse over, check if
> > cell content is larger than the cell width, then add tooltip to the column
> > by setting cell content in the title attribute.
> >
> > Please find attached patch and review.
>
> This has been taken care of in Murtuza's patch to move to SlickGrid.
> Please check with him to ensure you've got the best solution between
> both your patches. I won't commit this.
As far as I know, we are using SlickGrid in query tool only or we will be replacing BackGrid with SlickGrid in pgAdmin4 everywhere?
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

On Thu, Aug 18, 2016 at 5:26 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> On Aug 18, 2016 9:42 PM, "Dave Page" <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Aug 18, 2016 at 1:39 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi
>> >
>> > Issue:
>> > The table column data is incomplete for columns having more character
>> > lengths.
>> >
>> > Solution:
>> > Extends Backgrid.Cell and add 'mouseover' event. On mouse over, check if
>> > cell content is larger than the cell width, then add tooltip to the
>> > column
>> > by setting cell content in the title attribute.
>> >
>> > Please find attached patch and review.
>>
>> This has been taken care of in Murtuza's patch to move to SlickGrid.
>> Please check with him to ensure you've got the best solution between
>> both your patches. I won't commit this.

> As far as I know, we are using SlickGrid in query tool only

Good point - patch applied, thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company